15:31:04 <dalley> #startmeeting Pulp Triage 2018-01-23
15:31:04 <dalley> !start
15:31:04 <dalley> #info dalley has joined triage
15:31:04 <pulpbot> Meeting started Tue Jan 23 15:31:04 2018 UTC and is due to finish in 60 minutes.  The chair is dalley. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:31:04 <pulpbot> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:31:04 <pulpbot> The meeting name has been set to 'pulp_triage_2018_01_23'
15:31:04 <pulpbot> dalley: dalley has joined triage
15:31:19 <asmacdo> !here
15:31:19 <asmacdo> #info asmacdo has joined triage
15:31:19 <pulpbot> asmacdo: asmacdo has joined triage
15:31:26 <misa> !here
15:31:26 <misa> #info misa has joined triage
15:31:26 <pulpbot> misa: misa has joined triage
15:31:29 <ttereshc> !here
15:31:29 <ttereshc> #info ttereshc has joined triage
15:31:29 <pulpbot> ttereshc: ttereshc has joined triage
15:31:42 <dalley> !next
15:31:42 <preethi> !here
15:31:43 <pulpbot> dalley: 3 issues left to triage: 3307, 3308, 3310
15:31:43 <dalley> #topic import_upload: unit_key can no longer be None - http://pulp.plan.io/issues/3307
15:31:43 <preethi> #info preethi has joined triage
15:31:44 <pulpbot> Issue #3307 [NEW] (unassigned) - Priority: Normal | Severity: Medium
15:31:45 <pulpbot> import_upload: unit_key can no longer be None - http://pulp.plan.io/issues/3307
15:31:46 <pulpbot> preethi: preethi has joined triage
15:32:04 <jortel> !here
15:32:04 <jortel> #info jortel has joined triage
15:32:04 <pulpbot> jortel: jortel has joined triage
15:32:23 <ichimonji10> ttereshc, Replied to https://pulp.plan.io/issues/3310#note-4
15:32:37 <ipanova> !here
15:32:37 <ipanova> #info ipanova has joined triage
15:32:37 <pulpbot> ipanova: ipanova has joined triage
15:33:53 <dalley> should we consider this a documentation fix?
15:34:16 <ipanova> i don't see any semver braking change, i think in out api docs we have this key as required key, so i do think it was a bug which was fixed and rolling it back to None is a bad idea imho
15:34:38 <milan_> #info milan_ has joined triage
15:34:38 <milan_> !here
15:34:38 <pulpbot> milan_: milan_ has joined triage
15:35:07 <jortel> agreed.  the 2.15 fix is correct
15:35:27 <misa> I propose to move 3307 to core, and add validation
15:35:28 <ipanova> https://docs.pulpproject.org/dev-guide/integration/rest-api/content/upload.html?highlight=unit_key#import-into-a-repository
15:35:29 <jortel> seems like a wontfix
15:35:40 <ipanova> no "*optional* for unit_key
15:36:03 <misa> ipanova: but unit_metadata is optional and will fail the same way
15:36:40 <ipanova> misa: let's move to core and rename the issue to " improve validation'
15:36:45 <ipanova> durinf upload
15:36:47 <ipanova> :)
15:37:39 <misa> That's what I was proposing, more or less
15:37:59 <dalley> !propose other accept, move issue to core, rewrite to an improve validation issue
15:37:59 <dalley> #idea Proposed for #3307: accept, move issue to core, rewrite to an improve validation issue
15:37:59 <pulpbot> dalley: Proposed for #3307: accept, move issue to core, rewrite to an improve validation issue
15:38:01 <asmacdo> improve validation and docs
15:38:10 <ttereshc> ichimonji10, thanks
15:38:19 <asmacdo> _1
15:38:22 <asmacdo> +1
15:38:38 <ichimonji10> ttereshc, Thank you.
15:38:48 <dalley> who will edit the issue?
15:39:18 <ipanova> misa: :-P?
15:39:27 <misa> I can, but I don't know if I can move it
15:39:40 <dalley> misa, you won't have to, I can
15:40:13 <misa> done
15:40:27 <dalley> !accept
15:40:27 <dalley> #agreed accept, move issue to core, rewrite to an improve validation issue
15:40:27 <pulpbot> dalley: Current proposal accepted: accept, move issue to core, rewrite to an improve validation issue
15:40:29 <pulpbot> dalley: 2 issues left to triage: 3308, 3310
15:40:29 <dalley> #topic Sync of unchanged importer update repo version - http://pulp.plan.io/issues/3308
15:40:31 <pulpbot> Issue #3308 [NEW] (unassigned) - Priority: Normal | Severity: Medium
15:40:32 <pulpbot> Sync of unchanged importer update repo version - http://pulp.plan.io/issues/3308
15:40:35 <ipanova> misa: ++
15:40:35 <pulpbot> ipanova: misa: 's karma is now 1
15:40:45 <dalley> misa++
15:40:45 <pulpbot> dalley: misa's karma is now 6
15:40:56 <misa> ipanova: see, you need to check your inputs :-P
15:41:45 <ipanova> misa: i don't argue on that
15:41:48 <asmacdo> this sounds like correct behavior to me kersom
15:42:38 <kersom> I was expecting the version of repo to be kept the same, and latest_sync date to be changed.
15:43:01 <kersom> since nothing has changed, why change the repo version.
15:43:40 <asmacdo> it actually creates a new repo version
15:43:44 <ttereshc> +1 to correct behavior
15:43:59 <kersom> I am not familiar with this functionality yet, and I talked with bizhang, I understood that she should like to discuss this behavior.
15:44:14 <ttereshc> asmacdo, I guess we have it somewhere described as a part of the design, do you recall where?
15:44:15 <jortel> IIRC, this is how it was designed.
15:44:35 <asmacdo> i dont know if that decision is documented
15:44:42 <jortel> kersom, but if you disagree with the design .. start a discussion on pulp-dev?
15:44:55 <kersom> I tried yesterday
15:45:12 <kersom> I was trying to understand first of all
15:45:22 <bizhang> ah yeah, kersom asked me but I wasn't sure if it was the correct  behavior
15:45:22 <ipanova> let's leave a comment on issue with explanation and skip until next triage
15:45:28 <ipanova> in case there would be more questions
15:45:37 <asmacdo> ok, hows this, lets skip for now, ill comment on the issue and close. kersom if you disagree, feel free to reopen
15:45:58 <dalley> works for me
15:46:11 <kersom> if we guys decide like that, I am ok with, I just dont see the benefit of doing this, but probably I do not know the reasoning
15:46:21 <asmacdo> we almost did it the way kersom expects, but there was a problem with asynchronous tasks, ill explain
15:47:18 <dalley> !propose triage other asmacdo will close and comment with a description of the reasoning
15:47:18 <pulpbot> dalley: (propose triage <priority> <severity> [target_release]) -- Propose triage values including priority, severity, and an optional target release.
15:47:34 <dalley> !propose other asmacdo will close and comment with a description of the reasoning
15:47:34 <dalley> #idea Proposed for #3308: asmacdo will close and comment with a description of the reasoning
15:47:34 <pulpbot> dalley: Proposed for #3308: asmacdo will close and comment with a description of the reasoning
15:47:39 <ttereshc> +1
15:47:55 <ipanova> +1
15:48:02 <jortel> +1
15:48:15 <dalley> !accept
15:48:15 <dalley> #agreed asmacdo will close and comment with a description of the reasoning
15:48:15 <pulpbot> dalley: Current proposal accepted: asmacdo will close and comment with a description of the reasoning
15:48:17 <dalley> #topic Pulp can't sync from some mirrorlists - http://pulp.plan.io/issues/3310
15:48:17 <pulpbot> dalley: 1 issues left to triage: 3310
15:48:19 <pulpbot> Issue #3310 [POST] (ttereshc) - Priority: Normal | Severity: Medium
15:48:20 <pulpbot> Pulp can't sync from some mirrorlists - http://pulp.plan.io/issues/3310
15:48:24 <ttereshc> !propose accept
15:48:24 <ttereshc> #idea Proposed for #3310: Leave the issue as-is, accepting its current state.
15:48:24 <pulpbot> ttereshc: Proposed for #3310: Leave the issue as-is, accepting its current state.
15:48:34 <ttereshc> that's my bad from yestrday
15:48:38 <dalley> it's already assigned, should we add to sprint?
15:48:44 <ttereshc> it's in post
15:48:47 <ttereshc> and on the sprint
15:48:54 <ttereshc> it blocks 2.15.1
15:49:19 <dalley> ah, it's changed since I loaded the page
15:49:23 <asmacdo> +1 accept
15:49:24 <dalley> +1
15:49:39 <dalley> !accept
15:49:39 <dalley> #agreed Leave the issue as-is, accepting its current state.
15:49:39 <pulpbot> dalley: Current proposal accepted: Leave the issue as-is, accepting its current state.
15:49:40 <pulpbot> dalley: No issues to triage.
15:49:44 <dalley> !end
15:49:44 <dalley> #endmeeting