14:30:33 <fao89> #startmeeting Pulp Triage 2020-06-23
14:30:33 <fao89> #info fao89 has joined triage
14:30:34 <pulpbot> Meeting started Tue Jun 23 14:30:33 2020 UTC.  The chair is fao89. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:30:34 <pulpbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
14:30:34 <pulpbot> The meeting name has been set to 'pulp_triage_2020-06-23'
14:30:34 <pulpbot> fao89: fao89 has joined triage
14:30:35 <daviddavis> #info daviddavis has joined triage
14:30:35 <daviddavis> !here
14:30:35 <pulpbot> daviddavis: daviddavis has joined triage
14:30:43 <ppicka> #info ppicka has joined triage
14:30:43 <ppicka> !here
14:30:43 <pulpbot> ppicka: ppicka has joined triage
14:31:06 <ttereshc> #info ttereshc has joined triage
14:31:06 <ttereshc> !here
14:31:06 <pulpbot> ttereshc: ttereshc has joined triage
14:31:08 <fao89> !next
14:31:09 <fao89> #topic https://pulp.plan.io/issues/7029
14:31:09 <pulpbot> fao89: 3 issues left to triage: 7029, 7018, 7003
14:31:11 <pulpbot> RM 7029 - daviddavis - NEW - Accessing content for a distribution that is not assigned returns 404 which is confusing
14:31:12 <pulpbot> https://pulp.plan.io/issues/7029
14:31:18 <dkliban> #info dkliban has joined triage
14:31:18 <dkliban> !here
14:31:18 <pulpbot> dkliban: dkliban has joined triage
14:31:22 <bmbouter> #info bmbouter has joined triage
14:31:22 <bmbouter> !here
14:31:22 <pulpbot> bmbouter: bmbouter has joined triage
14:31:48 <fao89> #idea Proposed for #7029: Leave the issue as-is, accepting its current state.
14:31:48 <fao89> !propose accept
14:31:48 <pulpbot> fao89: Proposed for #7029: Leave the issue as-is, accepting its current state.
14:32:01 <ggainey> #info ggainey has joined triage
14:32:01 <ggainey> !here
14:32:03 <pulpbot> ggainey: ggainey has joined triage
14:32:07 <dkliban> maybe add to sprint?
14:32:11 <dkliban> i don't feel too strongly
14:32:34 <bmbouter> what is the proposed fix?
14:32:39 <ttereshc> what's the suggestion?
14:32:42 <ttereshc> :)
14:32:51 <dkliban> to return some text with the error message
14:32:58 <ggainey> I think the idea is "more meaningful error message"?
14:33:02 <ggainey> heh, yeah that
14:33:04 <dkliban> that says that the distribution doesn't have anything associated with it
14:33:32 <mikedep333> #info mikedep333 has joined triage
14:33:32 <mikedep333> !here
14:33:32 <pulpbot> mikedep333: mikedep333 has joined triage
14:33:38 <ipanova> #info ipanova has joined triage
14:33:38 <ipanova> !here
14:33:38 <pulpbot> ipanova: ipanova has joined triage
14:33:47 <dkliban> 404: Distribution doesn't have a publication or repository version associated with it.
14:33:58 <daviddavis> +1
14:34:15 <ppicka> +1
14:34:15 <bmbouter> that osunds fine, a 404 error code still seems right and this is more helpufl
14:34:17 <bmbouter> +1
14:34:21 <ggainey> concur
14:34:23 <ttereshc> +1
14:34:25 <ipanova> +1
14:34:27 <ggainey> let's add that as a comment please
14:34:32 <dkliban> i'll add it
14:34:36 <ggainey> thanks dkliban
14:34:47 <fao89> all these +1 means accept + add to sprint? Or just accept?
14:35:29 <ipanova> +1 to accept
14:35:34 <daviddavis> I think accept and have dkliban comment with the solution we just proposed
14:35:45 <dkliban> daviddavis: +1
14:36:03 <ggainey> +1
14:36:16 <fao89> #idea Proposed for #7029: accept + comment with the proposed solution
14:36:16 <fao89> !propose other accept + comment with the proposed solution
14:36:16 <pulpbot> fao89: Proposed for #7029: accept + comment with the proposed solution
14:36:21 <fao89> #agreed accept + comment with the proposed solution
14:36:21 <fao89> !accept
14:36:21 <pulpbot> fao89: Current proposal accepted: accept + comment with the proposed solution
14:36:21 <fao89> #topic https://pulp.plan.io/issues/7018
14:36:22 <pulpbot> fao89: 2 issues left to triage: 7018, 7003
14:36:23 <pulpbot> RM 7018 - wibbit - NEW - Broken Documentation Links
14:36:24 <pulpbot> https://pulp.plan.io/issues/7018
14:36:48 <bmbouter> move to container plugin and ask them to fix?
14:37:00 <ipanova> +1
14:37:02 <ttereshc> +1
14:37:04 <daviddavis> +1
14:37:08 <ppicka> +1
14:37:19 <fao89> #idea Proposed for #7018: move to container plugin
14:37:19 <fao89> !propose other move to container plugin
14:37:19 <dkliban> +1
14:37:32 <fao89> #agreed move to container plugin
14:37:32 <fao89> !accept
14:37:33 <pulpbot> fao89: Current proposal accepted: move to container plugin
14:37:33 <fao89> #topic https://pulp.plan.io/issues/7003
14:37:34 <pulpbot> fao89: 1 issues left to triage: 7003
14:37:35 <pulpbot> RM 7003 - dkliban@redhat.com - NEW - pulpcore-content allows for // in some parts of the URL but not others
14:37:36 <pulpbot> https://pulp.plan.io/issues/7003
14:38:12 <dkliban> we were going to discuss but i don't think we did
14:38:15 <dkliban> let's skip again
14:38:40 <fao89> !skip
14:38:41 <pulpbot> fao89: No issues to triage.
14:38:47 <fao89> Open floor!
14:39:02 <fao89> https://hackmd.io/@pulp/triage/edit
14:39:19 <fao89> The artifacts method on RepoVersion doesn’t return all artifacts https://pulp.plan.io/issues/7021
14:39:28 <ggainey> ah yes
14:39:38 <daviddavis> I added this. it's a problem I'm dealing with in exporting DistributionTrees
14:40:01 <daviddavis> we only export artifacts that are directly tied to repo version content
14:40:27 <daviddavis> one solution is to update RepositoryVersion.artifacts() to allow for plugin input
14:41:06 <daviddavis> I think the other viable solution would be to create a hook in the artifact export code to call a plugin function to get artifacts for a repo version
14:41:27 <daviddavis> thoughts?
14:41:33 <dkliban> i like both
14:41:35 <dkliban> lol
14:41:36 <daviddavis> hehe
14:42:00 <bmbouter> both solutions involve the plugin input right?
14:42:08 <bmbouter> one just defers 100% to that plugin and the other is additive?
14:42:42 <daviddavis> both solutions involve plugin input. I think both would be additive
14:43:02 <daviddavis> in the sense that plugins get the current behavior as the default behavior
14:43:25 <ipanova> so the hook in the export code will fix only the export path, if doing in artifacts() it will "fixed" in all places
14:43:34 <daviddavis> correct
14:43:34 <ipanova> daviddavis: ?
14:43:41 <daviddavis> that's the main difference I see
14:43:45 <ipanova> then i am +1 to artifacts()
14:44:10 <bmbouter> +1 to trying to fix it artifacts() for that reason
14:44:12 <ttereshc> what are the all places where artifacts() is used? do we want sub-repos there?
14:44:16 <daviddavis> there is a little bit of an ugly problem though: repo versions aren't typed so I think we'd have to call a method on Repository
14:44:28 <daviddavis> ttereshc: right now, only in the export/import code I think
14:44:36 <dkliban> daviddavis: that's ok
14:44:38 <bmbouter> daviddavis: that is ok I think
14:44:52 <bmbouter> it would take the repo version as a param so it's still repo version specific
14:45:02 <daviddavis> bmbouter: exactly
14:45:02 <ggainey> yus
14:45:21 <bmbouter> I think it's important to provide a base implementaiton that works in almost all cases will we be doing that?
14:45:38 <daviddavis> bmbouter: correct
14:45:59 <bmbouter> sounds good
14:46:13 <ttereshc> +1
14:46:33 <daviddavis> cool, I am going to double check on usages of artifacts() just in case somehow it got added somewhere else in the past few months
14:46:57 <ggainey> coolio
14:47:17 <ipanova> +1
14:47:17 <daviddavis> ty for the feedback
14:49:17 <bmbouter> ty for bringing this up!
14:51:47 <fao89> #endmeeting
14:51:47 <fao89> !end
14:28:17 <daviddavis> Triage will start in 2 min https://pulp.plan.io/issues?query_id=143
14:30:29 <daviddavis> !start
14:30:29 <daviddavis> #info daviddavis has joined triage
14:30:30 <pulpbot> daviddavis: Error: Can't start another meeting, one is in progress.
14:30:31 <pulpbot> daviddavis: daviddavis has joined triage
14:30:34 <daviddavis> #endmeeting
14:30:34 <daviddavis> !end
14:31:01 <daviddavis> #info daviddavis has joined triage
14:31:01 <daviddavis> !start
14:31:01 <pulpbot> daviddavis: Error: Can't start another meeting, one is in progress.
14:31:02 <pulpbot> daviddavis: daviddavis has joined triage
14:31:06 <daviddavis> and we're stuck ;(
14:31:29 <ggainey> oops
14:31:56 <dkliban> #info dkliban has joined triage
14:31:56 <dkliban> !here
14:31:57 <x9c4> a new pulpbot personality :+)
14:32:02 <ttereshc> pulpbot, !end
14:32:02 <pulpbot> ttereshc: Error: "!end" is not a valid command.
14:32:09 <ttereshc> !end
14:32:14 <fao89> !end
14:32:24 <daviddavis> #info daviddavis has joined triage
14:32:24 <daviddavis> !start
14:32:24 <pulpbot> daviddavis: Error: Can't start another meeting, one is in progress.
14:32:38 <dkliban> daviddavis: should i restart pulpbot?
14:32:39 <daviddavis> weird, I thoguht maybe only fao89 could end it
14:32:43 <daviddavis> dkliban: yes please